endimonan opened a new pull request, #42616:
URL: https://github.com/apache/superset/pull/42616

   ### SUMMARY
   
   Fixes #42613.
   
   The Current date range frame received the selected value but did not pass it 
to `Radio.GroupWrapper`, leaving the radio group uncontrolled. This passes the 
value through so the selected Current option is shown and adds a regression 
test.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **Before**
   
   The selected Current option was applied, but its radio button was not 
checked, as shown in #42613:
   
   <img width="1475" height="802" alt="Current date range without a selected 
radio button" 
src="https://github.com/user-attachments/assets/8a052885-c251-49a1-8109-1fc16917e23c";
 />
   
   **After**
   
   Not captured locally because no browser session was available. The 
regression test verifies that the radio matching the current value is checked.
   
   ### TESTING INSTRUCTIONS
   
   1. Open a Date Range filter.
   2. Select the Current frame and choose a value such as Current day.
   3. Reopen the filter and verify the corresponding radio button remains 
selected.
   4. Run:
      `npm run test -- 
src/explore/components/controls/DateFilterControl/tests/CurrentCalendarFrame.test.tsx`
   
   Automated validation:
   
   - Focused Jest suite: 3 tests passed.
   - Pre-commit hooks for the changed files, including TypeScript 
type-checking: passed.
   - `pre-commit run --all-files` was executed; unrelated baseline/environment 
failures remain in main mypy checks, generated frontend declarations in the 
clean validation environment, and the unavailable `helm-docs` binary.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: Fixes #42613
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to