rusackas commented on PR #42312: URL: https://github.com/apache/superset/pull/42312#issuecomment-5134413080
Good call — this one turned out to be a genuine bug in SQLAlchemy's own postgres dialect (not just a dialect quirk to work around): `get_schema_names()` uses `NOT LIKE 'pg_%'`, and `_` is a single-char SQL LIKE wildcard, so it's been silently over-matching for everyone on SQLAlchemy's Postgres dialect, not just Superset. Confirmed it's still present on their `main` branch too. Opened sqlalchemy/sqlalchemy#13471 upstream with the fix + a regression test. I'll add a TODO here linking to it so we remember to drop this override once it lands and we bump SQLAlchemy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
