sadpandajoe commented on code in PR #42595:
URL: https://github.com/apache/superset/pull/42595#discussion_r3685952870
##########
tests/unit_tests/models/helpers_test.py:
##########
@@ -2405,6 +2405,75 @@ def
test_get_sqla_query_allows_jinja_templated_custom_sql_metric_with_columns(
assert "{{" not in sql
+def test_get_sqla_query_virtual_dataset_filter_values_drill_to_detail(
+ database: Database,
+) -> None:
+ """
+ Regression for #35263: a Jinja-templated virtual dataset that calls
+ ``filter_values()`` in its own SQL must see filters sent in the native
+ ``{col, op, val}`` format that Drill to Detail/Drill by use, not just
+ the ``adhoc_filters`` format used by ordinary chart/explore requests.
+ Without this, Jinja-based datasets return zero rows when drilled into,
+ even though the parent chart shows data for the selected value.
+ """
+ from superset.connectors.sqla.models import SqlaTable, TableColumn
+
+ table = SqlaTable(
+ database=database,
+ schema=None,
+ table_name="t",
+ sql=(
+ "SELECT a, b FROM t WHERE 1=1 "
+ "{% if filter_values('b') %} "
+ "AND b IN {{ filter_values('b') | where_in }} "
+ "{% endif %}"
+ ),
+ columns=[
+ TableColumn(column_name="a", type="INTEGER"),
+ TableColumn(column_name="b", type="TEXT"),
+ ],
+ )
+
+ result = table.get_sqla_query(
+ columns=["a", "b"],
+ metrics=[],
+ extras={},
+ filter=[{"col": "b", "op": "IN", "val": ["Alice"]}],
+ granularity=None,
+ is_timeseries=False,
+ )
+ assert result is not None
+
+ with database.get_sqla_engine() as engine:
+ sql = str(
+ result.sqla_query.compile(
+ dialect=engine.dialect,
+ compile_kwargs={"literal_binds": True},
+ )
+ )
+
+ assert "'Alice'" in sql, (
+ "filter_values() should resolve native drill-to-detail-style "
+ f"filters inside a virtual dataset's own SQL. Generated SQL: {sql}"
+ )
+
+ # The assertion above can pass even when filter_values() itself is
+ # broken, because get_sqla_query() independently applies the native
+ # filter as an outer WHERE predicate on top of whatever the virtual
+ # dataset's own SQL renders to. Render the virtual dataset's SQL in
+ # isolation to confirm filter_values() actually resolved the native
+ # filter *inside* the templated subquery.
+ template_processor = table.get_template_processor(
Review Comment:
This still bypasses the `get_sqla_query()` wiring the regression is meant to
guard: if that method stops forwarding `filter` to its template processor, the
outer assertion still sees `Alice` and this direct renderer call still passes.
Could this assert the rendered inner subquery produced through
`result.sqla_query` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
