sadpandajoe commented on code in PR #42509:
URL: https://github.com/apache/superset/pull/42509#discussion_r3687069001
##########
.github/workflows/docker.yml:
##########
@@ -130,13 +130,25 @@ jobs:
# repeated --build-arg key, so appending PY_VER here overrides
# supersetbot's pin and keeps the build on the Dockerfile's own
# supported Python version.
+ #
+ # The "py311"/"py312" presets exist specifically to pin a
+ # *different* PY_VER than "dev"/"lean" (that's the whole point of
+ # those two presets), so they're excluded from this override.
+ # Without this exclusion, the PY_VER above clobbers theirs too
+ # (same last-value-wins rule), making "py311"/"py312" silently
+ # build the exact same image as "lean".
+ EXTRA_FLAGS="--build-arg INCLUDE_CHROMIUM=false --tag $IMAGE_TAG"
+ if [ "$BUILD_PRESET" != "py311" ] && [ "$BUILD_PRESET" != "py312" ];
then
Review Comment:
This fix can regress without any CI signal: workflow-only changes do not
match the Docker change detector, the PR matrix contains only `dev`/`lean`, and
the affected `py311`/`py312` builds therefore first run after merge. Could we
add an always-on dry-run assertion for the effective `PY_VER` of each
full-matrix preset, or otherwise make this workflow execute and verify those
two branches on PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
