fitzee commented on PR #42624: URL: https://github.com/apache/superset/pull/42624#issuecomment-5138272277
Addressed the Griffen review in `830e6cb5d532f470c247b7c6c99712cb388bc6bd`: - **Soft-timeout observability:** added `reports.execute.celery_soft_timeout`, a task-level test, and explicit operator/customer-notification documentation. I did not add an in-band retry/outbox because delivery is not idempotent in this scope. - **Stale-WORKING race:** narrowed the change instead of hand-waving a CAS. A distinct recovery invocation no longer mutates the possibly-live worker's audit row; it records its own `ERROR` and unblocks the schedule. Same-`execution_id` replay still promotes its own row. Durable lost-row terminalization is documented as a lease/watchdog follow-up. - **Boot validation:** total budget, all reserves, and hard-limit grace are validated from `SupersetAppInitializer.pre_init`, with invalid/default config tests. - **Selenium coverage:** added an end-to-end wiring test for the shared clock, page-load timeout, WebDriverWait values, seconds units, animation clamp, and capture. - **Tiling compatibility:** restored the historical `dashboard_height > tile_height` guard and added a high-chart-count/short-dashboard regression test, preserving thumbnail behavior. - **PDF limitation:** documented that the synchronous builder has before/after cooperative checks but is not internally preemptible. Focused suite: **255 passed**. Changed-file pre-commit (including mypy, Ruff format/check, and pylint) passes. Mandatory all-files pre-commit was rerun; its failures remain unrelated base/environment issues already listed in the PR description. The PR remains draft while the new CI run is monitored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
