codeant-ai-for-open-source[bot] commented on code in PR #37299:
URL: https://github.com/apache/superset/pull/37299#discussion_r3689333263
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/utils.tsx:
##########
@@ -47,6 +47,7 @@ const COLUMN_SIZE_MAP: Record<TableSize, number> = {
lg: 100,
xl: 150,
xxl: 200,
+ xxxl: 360,
Review Comment:
**Suggestion:** The new `xxxl` width is only applied as an Ant Design column
width, but `TableCollection` still renders with `tableLayout="auto"`. In auto
layout, content can continue to influence column sizing, so filtering or
pagination can still recalculate the table and shift the Name column despite
these explicit widths. Change the shared table to fixed layout as part of this
change, or otherwise ensure the mapped widths are enforced. [incomplete
implementation]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Dataset list columns can shift after filtering or pagination.
- ⚠️ Chart list columns can shift with changing content.
- ⚠️ Dashboard list columns remain content-dependent.
- ⚠️ The shared TableCollection layout fix remains incomplete.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d406a7a1c7c94b608d705da0b6a5c811&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d406a7a1c7c94b608d705da0b6a5c811&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/TableCollection/utils.tsx
**Line:** 50:50
**Comment:**
*Incomplete Implementation: The new `xxxl` width is only applied as an
Ant Design column width, but `TableCollection` still renders with
`tableLayout="auto"`. In auto layout, content can continue to influence column
sizing, so filtering or pagination can still recalculate the table and shift
the Name column despite these explicit widths. Change the shared table to fixed
layout as part of this change, or otherwise ensure the mapped widths are
enforced.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37299&comment_hash=f48407f0669976d22e68e50f2b7e1c9811707b4a5c814a6e00879298f1b2ffdc&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37299&comment_hash=f48407f0669976d22e68e50f2b7e1c9811707b4a5c814a6e00879298f1b2ffdc&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
