bito-code-review[bot] commented on code in PR #42481:
URL: https://github.com/apache/superset/pull/42481#discussion_r3690563015
##########
superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx:
##########
@@ -92,6 +94,11 @@ export default function AlertStatusIcon({
lastStateConfig.label = t('Alert Triggered, In Grace Period');
lastStateConfig.status = AlertState.Grace;
break;
+ case AlertState.Retrying:
+ lastStateConfig.icon = Icons.Running;
+ lastStateConfig.label = t('Report retrying');
+ lastStateConfig.status = AlertState.Retrying;
+ break;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inconsistent conditional handling</b></div>
<div id="fix">
Removing the `isReportEnabled` conditional from the Retrying case creates
inconsistent behavior compared to all other alert states (Success, Working,
Error, Noop). When `isReportEnabled=false` (regular alerts), users will now see
'Report retrying' which is semantically incorrect. The label should remain
conditional like the other states in this switch.
</div>
</div>
<small><i>Code Review Run #ce0668</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
