mikebridge commented on PR #41551: URL: https://github.com/apache/superset/pull/41551#issuecomment-5143687095
### Disposition of the Codex capstone above Cross-referenced against the earlier 10-lens capstone and the fix batches on this branch — the two panels converge almost completely, which is good signal. Item-by-item: **Blockers** 1. **Integer-id reuse** (5 Codex lenses + 2 earlier lenses, independently) — backend follow-up against merged code, not a change in this PR; it is the top item of the backend bucket in the earlier capstone and gates broad `ENABLE_VERSIONING_CAPTURE` rollout, not this merge. 2. **SIP** — gates *upstream* release, not this fork's merge; the ask (amend SIP-210 or file the UI SIP, then the dev@ vote) is tracked in the earlier capstone's process bucket. 3. **Before/after evidence** — **closed**: screenshots of the panel, preview, confirmation, and restored result are now in the PR description, captured on a live flag-on stack. **High** - #6 (**dirty-state not re-checked at confirm time**) — **fixed in `075241a2f7`**: the gate now re-validates at the moment of mutation; regression test confirmed to fail without it. This was a genuine hole in the gate added earlier today — good catch. - #5 (OFFSET lookup) and #4 (baseline retention backdating + clock mixing) — confirmed real by both panels; backend follow-ups. - #1 (kind registry), #2 (preview effect state machines), #3 (60s heuristic → backend correlation identity) — match the earlier capstone's post-merge/upstream buckets. **Medium/Low** — 24 of 26 map to items already fixed on this branch (`newestGroup` probe, bind-limit chunking noted for backend, mid-apply race, 'OK' sentinel documented, mutation locks known) or to the recorded backend/post-merge buckets. Two are **new to the follow-up list** and now recorded: silent capture drop when the schema is missing mid-deployment (`listener.py:396`), and the two obsoletely-skipped integration tests (`activity_view_tests.py:513,659`). Net: nothing in this review blocks this PR's merge; one High produced a same-day fix, one Blocker was closed by attaching the screenshots, and the rest sharpens the already-tracked backend and post-merge lists. _Triaged by Claude (AI) on behalf of @mikebridge._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
