aminghadersohi opened a new pull request, #42658: URL: https://github.com/apache/superset/pull/42658
### SUMMARY Expose per-column table formatting in MCP chart configurations. Table configs can set `columnWidth`, `d3NumberFormat`, and `d3TimeFormat`, keyed by result column label, and the generated schema documents concrete D3 format examples. Existing table `column_config` values are preserved when an update omits the field, while explicit values are validated and serialized without silently dropping unknown settings. ### TESTING INSTRUCTIONS ```bash pytest -q tests/unit_tests/mcp_service/chart/test_new_chart_types.py tests/unit_tests/mcp_service/chart/tool/test_get_chart_type_schema.py tests/unit_tests/mcp_service/chart/tool/test_update_chart.py tests/unit_tests/mcp_service/chart/tool/test_update_chart_preview.py uvx pre-commit run --files superset/mcp_service/chart/chart_utils.py superset/mcp_service/chart/schemas.py superset/mcp_service/chart/tool/update_chart.py superset/mcp_service/chart/tool/update_chart_preview.py tests/unit_tests/mcp_service/chart/test_new_chart_types.py tests/unit_tests/mcp_service/chart/tool/test_get_chart_type_schema.py tests/unit_tests/mcp_service/chart/tool/test_update_chart.py tests/unit_tests/mcp_service/chart/tool/test_update_chart_preview.py ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [x] Introduces new feature or API - [ ] Removes existing feature or API ### BLAST RADIUS Limited to MCP table chart configuration schemas and form-data mapping. It does not change authorization, database models, migrations, or non-MCP chart behavior. ### RISK AND ROLLBACK The main risk is accepting a formatting value that the frontend renders differently than expected. Validation constrains field names and primitive types, and rollback is a normal revert with no data migration. ### REVIEW GUIDANCE Start with `TableColumnConfig` in `schemas.py`, then review the form-data mapping and preservation paths in the two update tools. ### EVAL EVIDENCE The deterministic schema and round-trip paths are covered by 189 passing focused MCP unit tests. No model-based evaluation suite was available in this checkout. ### COST AND LATENCY DELTA No prompt, model, routing, or tool-call changes. The added local schema validation and dictionary serialization have negligible request cost and latency impact. ### PROMPT / NON-DETERMINISM No prompt or non-deterministic behavior changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
