sadpandajoe commented on code in PR #42484:
URL: https://github.com/apache/superset/pull/42484#discussion_r3693705686
##########
superset/utils/slack.py:
##########
@@ -185,11 +185,10 @@ def _get_channels(
)
return channels
except SlackApiError as ex:
- logger.error(
+ logger.warning(
Review Comment:
This catch also downgrades rate limits and Slack server/API failures, so
those actionable outages lose both ERROR-level capture and the traceback even
though only invalid or revoked credentials are expected noise. Could we reserve
WARNING for the intended auth error codes and keep ERROR logging for the other
`SlackApiError` branches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
