eschutho commented on code in PR #42118:
URL: https://github.com/apache/superset/pull/42118#discussion_r3693769604
##########
superset/utils/screenshot_utils.py:
##########
@@ -286,6 +315,15 @@ def take_tiled_screenshot(
# match `except PlaywrightTimeout` and incorrectly propagate instead of
# degrading to `None` like every other unexpected error in this function.
readiness_timeout = False
+ # Cap the whole tiled operation against the running Celery task's own
+ # time limit, using the same runtime derivation as the non-tiled
+ # readiness wait (#42253/#42427). Unlike that path, a None budget does
+ # not mean "keep the configured timeout": per-tile waits accumulate, so
+ # the operation falls back to a fixed total ceiling instead.
+ wait_budget_seconds = resolve_screenshot_task_budget_seconds(log_context)
+ if wait_budget_seconds is None:
+ wait_budget_seconds = float(TILED_SCREENSHOT_TOTAL_WAIT_BUDGET_SECONDS)
+ start_time = time.monotonic()
Review Comment:
Good catch, and agreed it deserved both-paths-on-one-clock: implemented
exactly as suggested (all three coordinated changes) in follow-up #42661, with
tests pinning that pre-capture elapsed time now reduces the first tile's capped
wait, and that the omitted-anchor default is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
