bxsx commented on code in PR #42495: URL: https://github.com/apache/superset/pull/42495#discussion_r3694184864
########## docker/pythonpath_dev/superset_config.py: ########## @@ -114,7 +114,13 @@ class CeleryConfig: } EXTENSIONS_PATH = "/app/docker/extensions" ALERT_REPORTS_NOTIFICATION_DRY_RUN = True -WEBDRIVER_BASEURL = f"http://superset_app{os.environ.get('SUPERSET_APP_ROOT', '/')}/" # When using docker compose baseurl should be http://superset_nginx{ENV{BASEPATH}}/ # noqa: E501 +# The Docker Compose app service is named "superset" and listens on 8088. Report +# paths are root-relative, so urljoin drops the base path; only the scheme, host, +# and port must be correct here. SUPERSET_APP_ROOT is kept for consumers that +# concatenate paths directly (e.g. cache warm-up). For screenshots in the dev +# stack (unbuilt static assets) point this at the nginx service instead: +# http://nginx{SUPERSET_APP_ROOT}/ +WEBDRIVER_BASEURL = f"http://superset:8088{os.environ.get('SUPERSET_APP_ROOT', '/')}/" Review Comment: This is the same trade-off discussed in the earlier thread on this line (and captured in the review instruction saved there): `nginx` exists only in the dev `docker-compose.yml` — `docker-compose-non-dev.yml` shares this config file via the `PYTHONPATH` set in `docker/.env` and has no `nginx` service, so making it the default would fix dev screenshots at the cost of breaking every worker-built URL on the non-dev stack. `http://superset:8088` is the default that maximizes what works out of the box: chart-data fetches (alerts, text/CSV reports) work on both stacks, screenshots work on non-dev (built assets), and the dev-screenshot override is documented in the comment directly above this line (`http://nginx{SUPERSET_APP_ROOT}/`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
