codeant-ai-for-open-source[bot] commented on code in PR #42624:
URL: https://github.com/apache/superset/pull/42624#discussion_r3694428481
##########
superset/commands/report/execute.py:
##########
@@ -1070,6 +1349,12 @@ def _send(
self.update_report_schedule_slack_v2()
recipient.type = ReportRecipientType.SLACKV2
notification = create_notification(recipient,
notification_content)
+ log_report_delivery_phase(
+ report_context,
+ recipient.type,
+ "retry",
+ enforce_budget=True,
+ )
notification.send()
Review Comment:
**Suggestion:** The Slack fallback sends the notification after upgrading
from v1 to v2 but never records a `complete` delivery phase. Successful
fallback deliveries therefore produce only `start` and `retry` events, causing
phase-level monitoring and delivery audit logic to report an incomplete
delivery even though the notification succeeded. Emit the same completion event
after the retry send. [incomplete implementation]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ Slack fallback telemetry lacks successful completion.
- โ ๏ธ Delivery diagnostics show an incomplete phase sequence.
- โ ๏ธ Operators cannot distinguish retry success from interruption.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b3153abbf6dc44bfb5139ea872ad7e43&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b3153abbf6dc44bfb5139ea872ad7e43&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/report/execute.py
**Line:** 1352:1358
**Comment:**
*Incomplete Implementation: The Slack fallback sends the notification
after upgrading from v1 to v2 but never records a `complete` delivery phase.
Successful fallback deliveries therefore produce only `start` and `retry`
events, causing phase-level monitoring and delivery audit logic to report an
incomplete delivery even though the notification succeeded. Emit the same
completion event after the retry send.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42624&comment_hash=9066cf0b7de0dda067156aa06e326bd9073123e798a8769e3e2f8ec17f2fda4b&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42624&comment_hash=9066cf0b7de0dda067156aa06e326bd9073123e798a8769e3e2f8ec17f2fda4b&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
