sadpandajoe commented on PR #42507: URL: https://github.com/apache/superset/pull/42507#issuecomment-5149776614
Review findings at `abb698f683961f5acd6d764e34ba16fd5beba3b4`: 1. **The E2E and Python-integration timeline jobs are not actually terminal.** In `.github/workflows/superset-e2e.yml:344-346`, `actions-timeline` needs the test jobs, but not the downstream `cypress-matrix-required` / `playwright-tests-required` jobs. The PR run demonstrates the race: the timeline job started at 05:39:53Z while `playwright-tests-required` ran until 05:39:58Z ([run](https://github.com/apache/superset/actions/runs/30331504302)). The same DAG issue exists in `.github/workflows/superset-python-integrationtest.yml:259-260`, where `test-postgres-required` is downstream of `test-postgres` but absent from the timeline's `needs`. Please depend on the actual leaf/required jobs so the fetched snapshot is guaranteed complete. 2. **Three matrix workflows still register one timeline action per matrix copy.** `superset-playwright.yml:58-62,82-85` always creates two copies; `pre-commit.yml:29-38` and `superset-extensions-cli.yml:25-36` create two on push/schedule. Each post hook independently fetches the whole run, producing duplicate summaries and allowing the first-finishing copy to snapshot the other while it is still running—the exact race the dedicated-job design is intended to avoid. In the PR's Playwright run, the two matrix jobs finished 12 seconds apart ([run](https://github.com/apache/superset/actions/runs/30331504318)). These should use one terminal `actions-timeline` job depending on the matrix job. Security review found the action is immutably pinned and permissions are appropriately read-only. Workflow validation, zizmor, and the PR's checks pass; these findings concern completeness and determinism of the generated timelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
