Herestothegamers commented on PR #42603: URL: https://github.com/apache/superset/pull/42603#issuecomment-5161768372
Rebased onto latest master and re-pushed. The earlier red ❌ checks were all cancelled at the checkout step before any code was tested — not actual failures. The current workflow runs for the new head are pending first-time-contributor approval. Could a maintainer please approve the workflow runs, and review when you get a chance? All review feedback so far has been addressed on the branch: - `normalize_schema` docstring added - `clearModal` resets schema to `''` to match `defaultUploadInfo` - test helper param renamed `selectSchema` → `omitSchema` - allow-list comparison in `schema_allows_file_upload` is now case-insensitive (matching the schemas endpoint's `upload_allowed` filtering) Locally, pre-commit (mypy/ruff/pylint/eslint) and the touched test suites all pass: upload command unit tests, database API unit tests, and the `UploadDataModal` frontend tests. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
