codeant-ai-for-open-source[bot] commented on code in PR #41551:
URL: https://github.com/apache/superset/pull/41551#discussion_r3704253467
##########
superset-frontend/src/dashboard/types.ts:
##########
@@ -123,6 +123,7 @@ export type DashboardState = {
isFiltersRefreshing: boolean;
hasUnsavedChanges: boolean;
dashboardIsSaving: boolean;
+ lastModifiedTime?: number;
Review Comment:
**Suggestion:** The new field is declared as numeric, but dashboard
hydration assigns `dashboard.changed_on`, which is a timestamp string, while
save reducers later populate the same field with numeric `last_modified_time`
values. This violates the state contract and causes consumers to receive
inconsistent representations; normalize `changed_on` to milliseconds before
assigning it or type the field consistently with the actual value. [type error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Dashboard hydration violates the `DashboardState` timestamp contract.
- ❌ Frontend type checking can fail on the normal dashboard-load path.
- ⚠️ Save and overwrite flows receive inconsistent timestamp representations.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b5647ee8c64349a9ba3083c90c7591e1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b5647ee8c64349a9ba3083c90c7591e1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dashboard/types.ts
**Line:** 126:126
**Comment:**
*Type Error: The new field is declared as numeric, but dashboard
hydration assigns `dashboard.changed_on`, which is a timestamp string, while
save reducers later populate the same field with numeric `last_modified_time`
values. This violates the state contract and causes consumers to receive
inconsistent representations; normalize `changed_on` to milliseconds before
assigning it or type the field consistently with the actual value.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41551&comment_hash=e3ccd6e196626c19d35c3c50bcb6033f64753392ba6e78c62c960bd92cce5ef1&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41551&comment_hash=e3ccd6e196626c19d35c3c50bcb6033f64753392ba6e78c62c960bd92cce5ef1&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
