mikebridge opened a new pull request, #42710: URL: https://github.com/apache/superset/pull/42710
### SUMMARY Two activity-view integration tests were skipped waiting on work that has since merged: - `test_activity_excludes_records_after_retention_prune` waited on the retention prune extracted to sc-111099; `_prune_old_versions_impl` is now in `superset/tasks/version_history_retention.py`. - `test_activity_surfaces_dashboard_restore_event` waited on the restore endpoint, which landed in #42469. It passes with no changes. The retention test needed one substantive update beyond removing the decorator: it was written against an age-only prune, but the shipped prune **preserves any transaction still anchoring an open shadow row** (`end_transaction_id IS NULL`) — an entity's current state is never dropped, however old. The test's single edit created exactly that row, so the prune correctly removed nothing and the assertion could never pass. The test now edits the chart twice: the second edit closes the first edit's shadow row, making the first transaction genuinely prunable, and the assertions exercise the keep-live guard as a side effect (the live transaction survives despite being backdated past the cutoff). Full file passes 40/40 against the integration SQLite DB. Disclosure: this change was developed with AI assistance (Claude), on behalf of and reviewed by @mikebridge. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — test-only change. ### TESTING INSTRUCTIONS ``` pytest tests/integration_tests/versioning/activity_view_tests.py ``` 40 passed (was 38 passed, 2 skipped). The two un-skipped tests are `TestDashboardActivityView::test_activity_excludes_records_after_retention_prune` and `TestDashboardActivityView::test_activity_surfaces_dashboard_restore_event`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
