rusackas commented on PR #39434: URL: https://github.com/apache/superset/pull/39434#issuecomment-5173049040
Thanks for sticking with this! While we await more input, this needs a cleanup pass. There's a `// ADD THIS LINE` and `// INJECTED COMPONENT` still sitting in the diff, and the `safeStringify`/license-header changes look unrelated to the label_colors GUI if I'm not mistaken. CI's also red across pre-commit, lint, and most of the test suites. Lastly, there are a bunch of bot comments to assess/address too, if you don't mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
