rusackas commented on PR #37014: URL: https://github.com/apache/superset/pull/37014#issuecomment-5173429125
Rebased this onto `master` and reconciled it with #41391, which landed in the meantime with a fixed hour-offset fix for the same `get_time_filter` method. They layer now instead of conflicting: the DST-aware timezone conversion here takes precedence when `extra.timezone` is configured, and falls back to the existing Hour Offset exactly as before when it's not. Also cleared the two open Codeant threads on `get_time_filter`. `get_dataset_timezone` now guards against a non-string `timezone` value, and the epoch-rendering concern turned out to already be fixed on `master` separately, so I added a test pinning it to this path. Unit tests pass locally, running CI now 🤞. Nice direction on this one originally, @jayakarkatika. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
