bito-code-review[bot] commented on code in PR #42731: URL: https://github.com/apache/superset/pull/42731#discussion_r3709342911
########## superset/sql/parse.py: ########## @@ -48,7 +48,15 @@ ) from superset.exceptions import QueryClauseValidationException, SupersetParseError -from superset.sql.dialects import DB2, Dremio, Firebolt, OpenSearch, Pinot, Vertica +from superset.sql.dialects import ( + DB2, + Dremio, + Firebolt, + Hana, + OpenSearch, + Pinot, + Vertica, +) Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing dialect registration test</b></div> <div id="fix"> The change correctly adds the `Hana` dialect to `SQLGLOT_DIALECTS` but lacks the explicit registration test that other custom dialects (Pinot, OpenSearch) have. Consider adding `test_hana_dialect_registered()` following the established pattern in `pinot_tests.py:24-31` to ensure future refactors don't accidentally break the mapping. </div> </div> <small><i>Code Review Run #658f8c</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
