AadityaAnand commented on code in PR #42678:
URL: https://github.com/apache/superset/pull/42678#discussion_r3712718639
##########
superset/utils/pandas_postprocessing/resample.py:
##########
@@ -47,7 +55,18 @@ def resample(
)
if method == "asfreq" and fill_value is not None:
- _df = df.resample(rule).asfreq(fill_value=fill_value)
+ origin = time_range_start if time_range_start is not None else
"start_day"
+ _df = df.resample(rule, origin=origin).asfreq(fill_value=fill_value)
Review Comment:
Thanks for catching this. I updated the implementation to normalize the
query boundaries so they match the DataFrame index’s timezone awareness before
passing them to resample(). I also added regression tests covering
timezone-aware and timezone-naive indexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
