rusackas commented on PR #42559: URL: https://github.com/apache/superset/pull/42559#issuecomment-5185841878
One thing before I approve. Codeant's thread here is still open: the early return also blocks deselecting an already-selected `Other`/unknown value, not just new invalid ones, since it returns before ever checking `selected.includes(value)`. Bito's suggested tweak, only short-circuit when the value isn't already selected, seems like the safer fix and keeps the existing "clear by clicking again" behavior intact. @chkang-idk2 mind adding that check? Or... holler if you want me to push some changes here to get it across the finish line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
