rusackas commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r3717521887
##########
superset-frontend/src/features/home/EmptyState.tsx:
##########
@@ -76,12 +77,19 @@ export interface EmptyStateProps {
}
export default function EmptyState({ tableName, tab }: EmptyStateProps) {
+ const isMobile = useIsMobile();
Review Comment:
Added tests for the button being withheld on mobile outside the favorites
tab, and still showing for it.
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -923,6 +965,36 @@ const DashboardBuilder = () => {
`}
/>
)}
+ {/* Mobile filters drawer */}
+ {!isNotMobile && nativeFiltersEnabled && (
Review Comment:
Good catch, added the hasFilters guard so it matches the header trigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
