rusackas commented on PR #42485: URL: https://github.com/apache/superset/pull/42485#issuecomment-5187415776
Thanks @asdf2014, and thanks @SkinnyPigeon too, whose #42480 for this same bug just merged. This one goes further though: it also fixes a real bug in `hydrateExplore.ts` (the derivation was writing through onto the caller's object, which corrupts the module-level fallback datasource used on a failed chart load), moves the derivation into `setDatasource` itself so it's not scoped to just the one call site, and centralizes it into a shared `getCurrencyFormats` helper that a `dashboards.ts` call site #42480 never touched needed too. I'd already left an LGTM here before #42480 landed, so I missed the overlap. Rebasing onto `master` myself now to keep the more complete fix. Looking forward to the follow-up you mentioned for the dashboard-side gaps once this lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
