sadpandajoe commented on code in PR #42737:
URL: https://github.com/apache/superset/pull/42737#discussion_r3718122469
##########
superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.tsx:
##########
@@ -601,7 +602,7 @@ export const useExploreAdditionalActionsMenu = (
const menuItems = [];
// Edit chart properties
- if (slice) {
+ if (slice && canModifySlice) {
Review Comment:
This gate can still expose a properties editor that the API rejects: an
editor without `can_write Chart` passes `canModifySlice`, while a deployment
whose configured admin role is not literally `Admin` fails the frontend admin
check even though the backend accepts it. Could this predicate include the
route-level write permission and use the configured admin signal so menu
visibility matches `ChartRestApi.put`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
