rusackas commented on code in PR #42608:
URL: https://github.com/apache/superset/pull/42608#discussion_r3718170787
##########
superset-frontend/plugins/plugin-chart-point-cluster-map/package.json:
##########
@@ -28,7 +28,7 @@
"dependencies": {
"@math.gl/web-mercator": "^4.1.0",
"mapbox-gl": "^3.26.0",
- "maplibre-gl": "^5.24.0",
+ "maplibre-gl": "^6.0.0",
Review Comment:
Good catch. react-map-gl 8.1.1's maplibre adapter reads `map.transform`
directly, which 6.0 removed. Bumped both plugins to 8.1.2, the release that
swaps in the public getters instead. Pushed with the lockfile regenerated.
##########
superset-frontend/plugins/preset-chart-deckgl/package.json:
##########
@@ -45,7 +45,7 @@
"d3-scale": "^4.0.2",
"handlebars": "^4.7.9",
"lodash": "^4.18.1",
- "maplibre-gl": "^5.24.0",
+ "maplibre-gl": "^6.0.0",
Review Comment:
Confirmed, @deck.gl/mapbox 9.3.7's `centerCameraOnTerrain` still reads
`map.transform` and there's no fixed release yet, checked 9.4.0-alpha.2 too and
it's the same. We don't expose terrain on our deck.gl configs today, but I'd
rather not carry the risk. Pinned preset-chart-deckgl back to maplibre-gl
^5.24.0 for now instead of holding up the rest of the bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
