sancho11 commented on issue #42788:
URL: https://github.com/apache/superset/issues/42788#issuecomment-5188287891
Thanks for confirming, and for digging into the migration state; I chased
#41730 a bit further and I think it resolves the ambiguity you flagged.
**#41730 never landed on `master`.** It was merged on July 3 into
`remove-legacy-viz-pipeline`, which is the head branch of #41714 (`chore(viz):
remove legacy explore_json + viz.py pipeline`). So the migration isn't in an
intermediate state; it's complete, just gated behind #41714. That's why the
legacy paths still look untouched from `master`.
And it does address both causes directly. From #41730:
```diff
// superset-frontend/plugins/preset-chart-deckgl/src/Multi/index.ts
- useLegacyApi: true,
+ loadBuildQuery: () => import('./buildQuery'),
```
with the new `Multi/buildQuery.ts` noting:
> The multi-layer chart issues no query of its own: every layer is a saved
chart fetched client-side through its own buildQuery
Once sub-layers are fetched through each layer's own `buildQuery` against
the v1 API:
- **Cause 1 disappears**: there's no `explore_json` request left to answer
with a `202`, and the v1 pipeline already resolves the async handoff correctly.
- **Cause 2 disappears**: the geometry is deserialized in
`layers/Polygon/transformProps.ts`, which already handles strings, pre-parsed
values and GeoJSON shapes. `DeckPathViz.get_properties` stops being reachable,
and `viz.py` goes away entirely with #41714.
So the practical question is just #41714's timeline. It currently reports
`mergeable_state: clean` and is under active review, which suggests it's close.
**On the PR you offered to take:** every line of the fix I have locally
targets code #41714 deletes:`explore_json` in `views/core.py`, `DeckPathViz`
and `DeckGLMultiLayer` in `viz.py`, and a `Multi.tsx` that #41730 rewrites. If
#41714 is landing soon, that PR is probably churn, and this issue is more
useful to you as a set of regression cases to verify the migration against:
1. A `deck_multi` chart with `GLOBAL_ASYNC_QUERIES` enabled and a cold
cache; every layer should render, not just the cached ones.
2. A Polygon layer whose `line_column` is a PostgreSQL `jsonb` column
(already parsed to a `list` by psycopg2), inside a `deck_multi` chart.
3. A `deck_multi` chart where one sub-layer fails; the remaining layers
should still render rather than the whole chart collapsing to the base map.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
