etr2460 commented on a change in pull request #8404: [WIP][feature]Dashboard
filter scope selector modal
URL:
https://github.com/apache/incubator-superset/pull/8404#discussion_r342183808
##########
File path: superset/assets/src/dashboard/reducers/dashboardFilters.js
##########
@@ -32,11 +31,13 @@ import { buildActiveFilters } from
'../util/activeDashboardFilters';
export const dashboardFilter = {
chartId: 0,
componentId: '',
+ filterName: '',
Review comment:
Personally, I think that empty string has a very different connotation in
code than null. Defaulting to null means that a value doesn't exist or was
never set. Defaulting to empty string means that this value does exist and was
set to `''`.
@williaster or @kristw, do you have any opinions on this? What have we been
doing in other parts of Superset/superset-ui?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
