reveha opened a new pull request, #42792: URL: https://github.com/apache/superset/pull/42792
- Extend canCrossFilterByXAxis to support AxisType.Time in addition to AxisType.Category, gated by !hasDimensions - Add temporal TEMPORAL_RANGE data mask generation using createTimeRangeFromGranularity (day/month/year granularities) - Apply +1ms adjustment to convert inclusive end to backend's upper-exclusive bound, per get_time_filter semantics in superset/models/helpers.py - Add triggerEvent: true for temporal x-axis when no dimensions are set, enabling axis-label click events - Register orientation-aware query event handler (xAxis/yAxis) guarded by targetType === 'axisLabel' for both categorical and temporal label clicks - Fix horizontal-orientation point click reading the wrong tuple index (metric value instead of axis value) for the temporal cross-filter path, using the same orientation-aware extraction as the categorical path - Add regression tests covering day/month/year point-click and axis-label-click payloads, toggle behavior, horizontal/vertical orientation, and no-op behavior when dimensions are set <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
