luizotavio32 commented on code in PR #42729:
URL: https://github.com/apache/superset/pull/42729#discussion_r3720368982
##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx:
##########
@@ -115,8 +115,9 @@ export default function DrillDetailPane({
state.common.conf.SAMPLES_ROW_LIMIT,
);
- const ROW_LIMIT = useSelector(
- (state: { common: { conf: JsonObject } }) => state.common.conf.ROW_LIMIT,
+ const exportRowLimit = useSelector(
+ (state: { common: { conf: JsonObject } }) =>
+ state.common.conf.DRILL_DETAIL_EXPORT_ROW_LIMIT,
);
Review Comment:
Good catch — fixed in 860ea0a. The selector now falls back to `ROW_LIMIT`
when `DRILL_DETAIL_EXPORT_ROW_LIMIT` is absent from the bootstrapped config, so
a newer frontend served against an older backend keeps the previous behavior
instead of sending `row_limit: undefined`. Added a unit test covering the
fallback.
##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx:
##########
@@ -239,7 +240,7 @@ export default function DrillDetailPane({
columns: [],
metrics: [],
orderby: [],
- row_limit: ROW_LIMIT,
+ row_limit: exportRowLimit,
Review Comment:
Good catch — fixed in 860ea0a. The selector now falls back to `ROW_LIMIT`
when `DRILL_DETAIL_EXPORT_ROW_LIMIT` is absent from the bootstrapped config, so
a newer frontend served against an older backend keeps the previous behavior
instead of sending `row_limit: undefined`. Added a unit test covering the
fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
