mikebridge commented on code in PR #42642: URL: https://github.com/apache/superset/pull/42642#discussion_r3721710326
########## superset/migrations/versions/2026-07-31_10-00_16755d4ca4ae_drop__customer_location_uc_take_2.py: ########## @@ -0,0 +1,91 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Drop _customer_location_uc (take 2) + +Revision ID: 16755d4ca4ae +Revises: e7d93a524ff6 Review Comment: Correct, and fixed in `a76280153e`. Introduced by the rebase onto current master: `down_revision` was re-pointed from `e7d93a524ff6` to `f3a8c1d2e9b7` (master gained the reports-retry migration from #42481 claiming the same parent, leaving two alembic heads) but the docstring header kept naming the old ancestor. Alembic reads the variable rather than the docstring, so the graph was correct and CI passed — the header was only misleading the next reader, which is precisely who reads a migration file: someone diagnosing a broken chain. Worth fixing for that reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
