mikebridge commented on PR #42797: URL: https://github.com/apache/superset/pull/42797#issuecomment-5194730911
Follow-up after implementation at `65cd23e4bc`: - **HIGH resolved:** `shadow_row_count()` now pins the baseline probe to `(id, uuid)`. - Added a behavioral regression covering predecessor capture → hard delete → successor creation with capture disabled → capture resumes → successor edit. It asserts that the successor receives its own baseline and update rows. - Added the missing type annotations and UUID narrowing found by the required full Python review. - **MEDIUM retracted:** deeper inspection showed `versioned_column_properties(target)` includes `uuid`. Even when the no-op lookup found a predecessor by reused integer id, the UUID comparison forced a mismatch, so it could not classify the successor as an identical no-op. I removed the unnecessary factory predicate/import instead of preserving unsupported code. Verification: 13 focused tests pass; affected-file pre-commit passes; the full repository pre-commit suite passes with only `oxfmt-frontend` skipped because that all-files hook rewrites 30 unrelated frontend files already outside this PR. The frontend formatter has no files in this Python-only diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
