rusackas commented on code in PR #42761:
URL: https://github.com/apache/superset/pull/42761#discussion_r3723321337
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/transformProps.ts:
##########
@@ -242,6 +243,7 @@ export default function transformProps(chartProps:
ChartProps<QueryFormData>) {
columnFormats,
currencyFormats,
metricsLayout,
+ showValuesAs,
Review Comment:
This isn't new though, the old aggregateFunction fraction display had the
exact same blind spot pre-#41184 (it was passed through transformProps the same
way, frontend-only). So exports were never in sync with the fraction-of display
even back then, this PR doesn't regress anything there. Fair follow-up if
someone wants export parity, but I don't think it should hold this one up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
