rusackas commented on code in PR #42500:
URL: https://github.com/apache/superset/pull/42500#discussion_r3724771380
##########
.github/workflows/pre-commit.yml:
##########
@@ -52,6 +52,16 @@ jobs:
- name: Install helm-docs
run: go install github.com/norwoodj/helm-docs/cmd/[email protected]
+ # Spike: run the existing .pre-commit-config.yaml through prek (a Rust
+ # reimplementation of pre-commit) instead of pre-commit itself, to see
+ # whether it's viable to speed up this job. CI-only — contributors keep
+ # installing/running `pre-commit` locally exactly as documented; nothing
+ # here changes that.
+ - name: Install prek
+ run: |
+ curl --proto '=https' --tlsv1.2 -LsSf
https://github.com/j178/prek/releases/download/v0.4.11/prek-installer.sh | sh
+ echo "$HOME/.cargo/bin" >> "$GITHUB_PATH"
Review Comment:
good catch, removed it. The installer already writes its actual install dir
to `GITHUB_PATH` itself (default is `~/.local/bin`, not `~/.cargo/bin`), so the
extra line was just wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
