mikebridge commented on PR #42746: URL: https://github.com/apache/superset/pull/42746#issuecomment-5203296710
@rusackas I think the problem with this PR seems to be that it bumped `oxfmt` from `0.60.0` to `0.61.0`, but only ran on the changed `pre-commit` files. Running `--all-files` on master locally with `0.61.0` shows that the rules changed, so this PR should fix master: - https://github.com/apache/superset/pull/42813 We should either make sure we follow the procedure outlined in AGENTS.md, or else change it: - https://github.com/apache/superset/blob/master/AGENTS.md#%EF%B8%8F-critical-always-run-pre-commit-before-pushing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
