Tamayi commented on issue #40576:
URL: https://github.com/apache/superset/issues/40576#issuecomment-5203642951
The `master` fix is confirmed, but this still ships broken on the release
branches. #38033's `RightMenu.tsx` change isn't on `origin/6.2`, which is
unreleased and still has `href={ensureAppRoot(navbarRight.user_logout_url)}` —
so 6.2.0 will ship the same double-prefixed logout that 6.1.0 did.
Verified by checking out each ref and evaluating the shipped `ensureAppRoot`
body against the values `menu_data` emits (`user_logout_url` =
`appbuilder.get_url_for_logout`, already SCRIPT_NAME-prefixed by Flask's
`url_for`):
```
origin/6.1 -> /app-superset/app-superset/logout/
origin/6.2 -> /app-superset/app-superset/logout/
origin/master -> /app-superset/logout/
```
#38033 has no milestone or cherry-pick label, so this doesn't look queued.
Could the one-line `RightMenu.tsx` hunk be cherry-picked to `6.2` before
release? The `ensureAppRoot` idempotence guard is also master-only, so the
`RightMenu.tsx` line alone is the minimal safe backport. Happy to open the
cherry-pick PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
