sancho11 commented on PR #41714: URL: https://github.com/apache/superset/pull/41714#issuecomment-5205853227
Thanks for picking 3 up; I looked at `e04112f` and it matches what I had locally, down to gating on the container and falling back to the per-chart reads in Explore, so there's nothing for me to add there. Glad the traces were useful. There is a fifth gap I ran into afterwards, and I'd rather ask than assume where it belongs. Composing layers loses the legend each of them shows standalone. `DeckGLPolygon` builds its metric buckets and `CategoricalDeckGLContainer` builds its category swatches, but both render the `<Legend>` from the layer's own React component, and `Multi.tsx` only ever calls `getLayer`, so those components are never mounted. The legend simply isn't there in Multiple Layers, and never has been. It's not something the migration broke. I have it working locally against the migrated `Multi.tsx`: the categories are rebuilt per layer from the features its own transform returned, reusing the same `getBuckets` / `getColorBreakpointsBuckets` / `getCategories` helpers the components use rather than reimplementing the logic, so it follows if those change. Layers sharing a corner are merged into one legend instead of stacking on top of each other, and there's a `show_legend` control on the container so a multi-layer map can drop them without editing the layer charts it composes. Defaults to on, and only an explicit `false` hides them, so saved charts keep their legends. This is a parity gap rather than a migration regression, though, and I don't want to grow the scope of a 616-file PR without checking. Happy either way. I can open it against this branch now, or hold it as a follow-up once this lands. Your call. One note if it goes on this branch: my version predates your test restructuring, so the legend tests would need to move into `MultiV1.test.tsx`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
