sadpandajoe commented on PR #42393:
URL: https://github.com/apache/superset/pull/42393#issuecomment-5208008284
Addressed review feedback in 596850c:
- **N+1 lookup** (Copilot / @aminghadersohi): skip the `uuid_owner` query
when the name-matched `obj` already owns the incoming uuid — the guard would
keep it anyway, so that's pure waste on the idempotent re-import path.
`superset/models/helpers.py:602`.
- **`config.get('table_name')` vs `config['uuid']` inconsistency**: switched
to `config['table_name']` for consistency; the field is `required=True` in
`ImportV1DatasetSchema`.
- **Mode bits**: restored 644 on the 5 files that were committed as
executable (`UPDATING.md`, `superset/datasets/schemas.py`,
`superset/models/helpers.py`, and the two test files).
Also merged latest `master` to resolve the conflict in `UPDATING.md` (both
branches added an entry under `## Next`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
