bito-code-review[bot] commented on code in PR #42053:
URL: https://github.com/apache/superset/pull/42053#discussion_r3732121900
##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -494,7 +495,7 @@ export type ConditionalFormattingConfig = {
targetValueLeft?: number;
targetValueRight?: number;
column?: string;
- colorScheme?: string;
+ colorScheme?: RGBColor | string;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>CWE-20: Type change makes alpha property
optional</b></div>
<div id="fix">
The `ConditionalFormattingConfig.colorScheme` type is being changed from
`RgbaColor` to `RGBColor`. These are semantically different: `RgbaColor`
requires the `a` (alpha) field while `RGBColor` marks it optional. Code in
`getColorFormatters.ts` accesses `.a` on colorScheme objects without guarding
for undefined (lines 308, 313). Changing the type to make `a` optional risks
runtime errors when existing code passes objects without an alpha value. Import
both types and keep the original `RgbaColor` binding to preserve the original
contract. (See also: [CWE-20](https://cwe.mitre.org/data/definitions/20.html))
</div>
</div>
<small><i>Code Review Run #be1e9b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
