vjymisal0 commented on PR #42881: URL: https://github.com/apache/superset/pull/42881#issuecomment-5213635452
Good catch — pushed a fix. `extraMetricLabels` is now resolved through `verboseMap` the same way `rebaseForecastDatum` renames the data keys, using the same `verboseMap[label] ?? label` fallback pattern already used elsewhere in this file. Added a regression test in `transformProps.test.ts` covering a verbose-named sort-only metric end to end (fails without the fix: total comes out to 34 instead of 32; passes with it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
