michael-s-molina commented on code in PR #42865:
URL: https://github.com/apache/superset/pull/42865#discussion_r3735849074
##########
superset-frontend/packages/superset-core/src/dashboard/index.ts:
##########
@@ -53,21 +53,52 @@
import type { Event } from '../common';
+/**
+ * How a container arranges its own children.
+ *
+ * - `grid` (the default, and what every node written before this field
+ * existed still means) — children occupy cells of the container's column
+ * grid and are compacted upward, so the space a removed or moved block
+ * leaves behind closes itself.
+ * - `free` — the same cells, uncompacted. A child stays exactly where it was
+ * put and may overlap a sibling. It reads the same four child fields
+ * `grid` does, so switching a container between the two never discards a
+ * position an author or an agent set.
+ * - `flex` — children flow along a line and wrap, sharing that line in
+ * proportion to their `colSpan` instead of occupying named cells. Their
+ * position is their order in `children`, not a coordinate.
+ *
+ * A flow is still not a mode, and the two that are here are the two that
+ * genuinely could not be expressed as a grid: `free` because compaction is a
+ * property of the container rather than of any child's coordinates, and
+ * `flex` because a proportional line has no cells to name.
+ */
+export type LayoutMode = 'grid' | 'free' | 'flex';
Review Comment:
Can you remove Canvas building block from the UI and its layout modes?
Containers are currently being discussed as part of the layout efforts.
##########
superset-frontend/src/core/dashboard/blocks/CanvasBlock.tsx:
##########
@@ -237,9 +295,24 @@ export default function CanvasBlock({ nodeId }: { nodeId:
string }) {
// a few mouse-move events. `"vertical"` resolves the same collision
// by moving the sibling down exactly once, by exactly its own
// height, every time.
- compactType="vertical"
+ //
Review Comment:
Let's remove this block for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
