willbarrett opened a new pull request #8511: Fix for BigQuery connection checks and CSV uploads URL: https://github.com/apache/incubator-superset/pull/8511 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Due to some inconsistencies in how we were creating SQLAlchemy Engines, a couple of features were broken with the new UI-based BigQuery connection method. This PR standardizes one instance of `create_engine` being called directly instead of through the Database model's `get_sqla_engine` function, adds consideration of a missing parameter to the connection check endpoint, and updates the CSV Upload system for BigQuery to look at the connection info provided to the SQLAlchemy Engine. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @nytai @mistercrunch @dpgaspar
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
