rusackas commented on code in PR #42863: URL: https://github.com/apache/superset/pull/42863#discussion_r3737222262
########## superset/migrations/versions/2026-08-06_18-00_b8d2f4a6c901_index_purge_audit_predecessor.py: ########## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""index purge audit predecessor lookup + +Revision ID: b8d2f4a6c901 +Revises: c4a1b8e2d739 +Create Date: 2026-08-06 18:00:00.000000 + +""" + +from superset.migrations.shared.utils import create_index, drop_index + +# revision identifiers, used by Alembic. +revision: str = "b8d2f4a6c901" +down_revision: str = "c4a1b8e2d739" Review Comment: Went looking for the pre-push single-alembic-head check you mentioned and couldn't find it anywhere in the repo, no pre-commit hook, no pre-push hook, no script. What was that actually running? Worth noting `c4a1b8e2d739` did fork shortly after this: master had two heads until #42878's merge revision fixed it. Opened #42890 to make this an actual enforced CI check going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
