bito-code-review[bot] commented on code in PR #42309: URL: https://github.com/apache/superset/pull/42309#discussion_r3737254594
########## superset-frontend/plugins/plugin-chart-country-map/src/countries.ts: ########## @@ -103,6 +103,7 @@ import iran from './countries/iran.geojson'; import israel from './countries/israel.geojson'; import italy from './countries/italy.geojson'; import italy_regions from './countries/italy_regions.geojson'; +import italy_regions_and_autonomous_provinces from './countries/italy_regions_and_autonomous_provinces.geojson'; Review Comment: <!-- Bito Reply --> The suggestion provided by the reviewer is appropriate. Adding test coverage for new country options ensures that display labels are correctly generated and rendered, which maintains consistency with the existing testing patterns in the plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
