bito-code-review[bot] commented on PR #42867:
URL: https://github.com/apache/superset/pull/42867#issuecomment-5220012142
<!-- Bito Reply -->
The suggestion is correct. While
`testWithAssets.setTimeout(TIMEOUT.SLOW_TEST)` increases the overall test
duration, it does not automatically propagate to the internal
`waitForChartsToLoad()` call, which uses a default 15-second timeout. To
resolve this, you should pass an explicit, longer timeout to
`waitForChartsToLoad()` to ensure it aligns with the increased test budget.
To implement this, update the call in
`superset-frontend/playwright/tests/dashboard/mixed-chart-dashboard-filters.spec.ts`
as follows:
**superset-frontend/playwright/tests/dashboard/mixed-chart-dashboard-filters.spec.ts**
```
const dashboard = new DashboardPage(page);
await dashboard.open(dashboardId);
await dashboard.waitForChartsToLoad({ timeout: TIMEOUT.SLOW_TEST });
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
