durgaprasadml commented on PR #42248: URL: https://github.com/apache/superset/pull/42248#issuecomment-5220218262
Hi @rusackas, thanks for taking another look and for the detailed feedback. Good catch on both points. * I've removed the unrelated `cellBarStyles`/`arrowStyles` formatting changes so this PR is now scoped strictly to the server pagination fix. * I've also updated the regression test to assert that `selectTrigger` exists before interacting with it, so the test will fail if the selector is ever missing instead of silently skipping the assertions. I've pushed the changes and resolved the merge conflict as well. Thanks again for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
