bito-code-review[bot] commented on code in PR #42856: URL: https://github.com/apache/superset/pull/42856#discussion_r3737816144
########## pyproject.toml: ########## @@ -248,7 +248,7 @@ redshift = ["sqlalchemy-redshift>=0.8.1, <0.9"] # and 2.0 (version numbers don't track SQLAlchemy compat monotonically); pin # to the newest 1.4-only release for now. Bump to >=2.0.0 in lockstep with # Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before. -risingwave = ["sqlalchemy-risingwave>=1.4.1, <2.0.0"] +risingwave = ["sqlalchemy-risingwave>=2.1.0, <3.0.0"] Review Comment: <!-- Bito Reply --> The suggestion provided by the reviewer is valid in its assessment that `sqlalchemy-risingwave>=2.1.0` typically requires SQLAlchemy 2.0+. Since the project's core dependency remains on SQLAlchemy 1.4, this change would indeed create an unsatisfiable dependency. Keeping the floor at `>=1.4.1` while widening the ceiling is an appropriate approach to maintain compatibility with the current core constraints. **pyproject.toml** ``` risingwave = ["sqlalchemy-risingwave>=1.4.1, <2.0.0"] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
