codecov[bot] commented on PR #42895: URL: https://github.com/apache/superset/pull/42895#issuecomment-5220692073
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42895?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `47.05882%` with `18 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.57%. Comparing base ([`38ba4a6`](https://app.codecov.io/gh/apache/superset/commit/38ba4a69bf02c03e0e2b2c055798425b42ffb155?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bbd6d54`](https://app.codecov.io/gh/apache/superset/commit/bbd6d54111fb7cf7dc33b4ac31151d36f807725a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/42895?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [superset/models/helpers.py](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&filepath=superset%2Fmodels%2Fhelpers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/connectors/sqla/models.py](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&filepath=superset%2Fconnectors%2Fsqla%2Fmodels.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | 14.28% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/mcp\_service/chart/chart\_utils.py](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Fchart_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvY2hhcnRfdXRpbHMucHk=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/db\_engine\_specs/base.py](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&filepath=superset%2Fdb_engine_specs%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../mcp\_service/chart/validation/dataset\_validator.py](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Fvalidation%2Fdataset_validator.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvdmFsaWRhdGlvbi9kYXRhc2V0X3ZhbGlkYXRvci5weQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rvice/chart/validation/runtime/format\_validator.py](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Fvalidation%2Fruntime%2Fformat_validator.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvdmFsaWRhdGlvbi9ydW50aW1lL2Zvcm1hdF92YWxpZGF0b3IucHk=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/42895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #42895 +/- ## ========================================== + Coverage 57.10% 65.57% +8.47% ========================================== Files 2857 2857 Lines 161125 161150 +25 Branches 37060 37064 +4 ========================================== + Hits 92014 105680 +13666 + Misses 68259 53459 -14800 - Partials 852 2011 +1159 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/42895/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/42895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.25% <44.11%> (+<0.01%)` | :arrow_up: | | [javascript](https://app.codecov.io/gh/apache/superset/pull/42895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.19% <ø> (-0.01%)` | :arrow_down: | | [presto](https://app.codecov.io/gh/apache/superset/pull/42895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.21% <44.11%> (+<0.01%)` | :arrow_up: | | [python](https://app.codecov.io/gh/apache/superset/pull/42895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.59% <47.05%> (+17.33%)` | :arrow_up: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/42895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.45% <47.05%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42895?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
