rusackas commented on code in PR #42803:
URL: https://github.com/apache/superset/pull/42803#discussion_r3738393017
##########
tests/unit_tests/extensions/test_sqlalchemy.py:
##########
@@ -286,7 +286,7 @@ def test_dml(
"(shillelagh.exceptions.ProgrammingError) DML not enabled in database "
'"database2"\n[SQL: INSERT INTO "database2.table2" (a, b) '
"VALUES (3, 'thirty')]\n(Background on this error at: "
- "https://sqlalche.me/e/14/f405)"
Review Comment:
Fair point — pinned to `/e/20/`, so this'll break the moment SQLAlchemy
bumps past 2.0. Normalized the version segment out of the comparison in
1a61d913662.
##########
tests/integration_tests/db_engine_specs/hive_tests.py:
##########
@@ -357,7 +357,9 @@ def test_where_latest_partition(mock_method):
columns,
)
query_result = str(result.compile(compile_kwargs={"literal_binds": True}))
- assert "SELECT \nWHERE ds = '01-01-19' AND hour = 1" == query_result
Review Comment:
Exact match is deliberate here — the whitespace difference *is* the thing
under test (2.0's select() with no columns renders one trailing space instead
of two). A prettifier would normalize that away and stop catching a regression
if 2.1 changes it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
