bito-code-review[bot] commented on PR #42733:
URL: https://github.com/apache/superset/pull/42733#issuecomment-5224520244
<!-- Bito Reply -->
The current test case in `tests/unit_tests/sql/parse_tests.py` uses a query
without a terminating semicolon (`LIMIT 100`). To cover the semicolon form and
ensure the issue remains open until the underlying formatting logic is
corrected, you can add a second test case or update the existing one to include
a semicolon.
Updating the test to include a semicolon would look like this:
```python
sql = """SELECT /*+ SET_VAR(query_timeout = 3000) */ col1, col2
FROM my_table
LIMIT 100;
-- increase timeout for large scans"""
```
This will verify if the formatter correctly handles the semicolon without
corrupting the optimizer hint block.
**tests/unit_tests/sql/parse_tests.py**
```
sql = """SELECT /*+ SET_VAR(query_timeout = 3000) */ col1, col2
FROM my_table
LIMIT 100;
-- increase timeout for large scans"""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
